Remove Transducers.jl dependency - #201
Merged
Merged
Conversation
Contributor
|
AbstractMCMC.jl documentation for PR #201 is available at: |
Remove the internal (unexported) `Sample` transducer and the Transducers.jl dependency, which brought in 11 transitive dependencies. The equivalent `steps()` / `Stepper` iterator interface remains available for lazy/streaming MCMC sampling. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
devmotion
force-pushed
the
dmw/rm_transducers
branch
from
March 26, 2026 23:43
1bf6f85 to
23e0e9d
Compare
penelopeysm
reviewed
Apr 5, 2026
penelopeysm
left a comment
penelopeysm
left a comment
Contributor
There was a problem hiding this comment.
Thanks @devmotion! Quite happy to remove it. There are a few remaining references to transducers in the docs, I'll go ahead and remove them too.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #201 +/- ##
===========================
===========================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #200.
Summary
Remove the internal (unexported)
Sampletransducer and the Transducers.jl dependency, which brought in 11 unique transitive dependencies (Accessors, ArgCheck, Baselet, CompositionsBase, ConstructionBase, DefineSingletons, InitialValues, Markdown, MicroCollections, SplittablesBase, Tables).The equivalent
steps()/Stepperiterator interface remains available for lazy/streaming MCMC sampling.Options considered
Three approaches were evaluated:
1. Package extension
Move
Sampletoext/AbstractMCMCTransducersExt.jl, make Transducers a weak dep.AbstractMCMC.Sample2. Separate package
Create
AbstractMCMCTransducers.jl.3. Remove completely (chosen)
AbstractMCMC.Sample(internal, unexported)steps()provides equivalent functionalityRationale: No known users, not exported, equivalent functionality exists via
steps(), and the issue author doubts anyone uses it. Option 1 adds complexity to preserve dead code; Option 2 is overkill.Test plan
using AbstractMCMCloads without error🤖 Generated with Claude Code